Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove unncecessary @AfterClass cleanup in LagReportingAgentFunctionalTest which is causing flakiness #4429

Merged
merged 2 commits into from Feb 3, 2020

Conversation

AlanConfluent
Copy link
Member

Description

Removes unnecessary @afterclass cleanup since this is setup across tests. This was the source of flakiness.

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@ghost
Copy link

ghost commented Feb 3, 2020

@confluentinc It looks like @AlanConfluent just signed our Contributor License Agreement. 👍

Always at your service,

clabot

Copy link
Contributor

@vinothchandar vinothchandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlanConfluent AlanConfluent merged commit e422b77 into confluentinc:master Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants