fix: support trailing slashes in listener URLs #5076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agavra
commented
Apr 16, 2020
Comment on lines
-332
to
-334
| if (!replaceHost && listener.getPort() > 0) { | ||
| return listener; | ||
| } |
There was a problem hiding this comment.
we can always sanitize - no reason not to (e.g. to remove the trailing slash)
agavra
force-pushed
the
fix_trailing_slash
branch
from
cfe0fce
to
f4f78e0
Compare
Co-authored-by: Steven Zhang <stevenz@confluent.io>
agavra
force-pushed
the
fix_trailing_slash
branch
from
f4f78e0
to
0a9aa32
Compare
vpapavas
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #4668
Testing done
unit testing, local testing spinning up a node with trailing slash and ran a query
Reviewer checklist