fix: allow dynamic construction of an ARRAY of STRUCTS with duplicate values #5436 #5506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @nae701 hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here. Once you've signed reply with Appreciation of efforts, clabot |
agavra
reviewed
May 28, 2020
ksqldb-execution/src/main/java/io/confluent/ksql/execution/codegen/CodeGenSpec.java
Outdated
Show resolved
Hide resolved
Comment on lines
126
to
127
| final String structSchemaName = CodeGenUtil.schemaName(structSchemaCount++); | ||
| structToSchemaName.put(struct, structSchemaName); | ||
| if (!structToSchemaName.containsKey(struct)) { |
There was a problem hiding this comment.
I think we should flip the semantics of the if statement here and instead return early if the structToSchemaName already contains the entry - that way we wont be incrementing structSchemaCount or adding the unnecessary argument to the argumentBuilder.
ksqldb-functional-tests/src/test/resources/query-validation-tests/create-struct.json
Show resolved
Hide resolved
agavra
reviewed
May 29, 2020
ksqldb-execution/src/main/java/io/confluent/ksql/execution/codegen/CodeGenSpec.java
Show resolved
Hide resolved
agavra
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What behavior do you want to change, why, how does your patch achieve the changes?
Error was occuring when user wants to create an array of structs with duplicate values. This patch fixes this by using a mutable hash map and then making an immutable hash map copy from that, since the immutable hash map builder did not check for duplicates but will fail once we try to build it.
Testing done
Describe the testing strategy. Unit and integration tests are expected for any behavior changes.
A new unit test was created in the create-struct.json that checks for this specific test case of duplicate values.
Reviewer checklist