fix: enable schema inference for timestamp/time/date #7737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spena
reviewed
Jun 28, 2021
| @@ -104,6 +107,24 @@ private static void checkMapKeyType(final Schema.Type type) { | |||
| } | |||
| } | |||
|
|
|||
| private static Schema convertInt64Schema(final Schema schema) { | |||
| if (schema.name() == Timestamp.LOGICAL_NAME) { | |||
| return Timestamp.builder().optional().build(); | |||
There was a problem hiding this comment.
It would be good to have a constant defined for this. Perhaps OPTIONAL_TIMESTAMP_SCHEMA? Same question for the convertInt32Schema.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7730
Adds logic to the schema converter to convert date/time/timestamp to their logical types rather than just int/bigint.
Testing done
QTT and manually tested.
Reviewer checklist