Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include checking the the config during validation of SET #8718

Merged
merged 2 commits into from Feb 4, 2022
Merged

feat: include checking the the config during validation of SET #8718

merged 2 commits into from Feb 4, 2022

Conversation

wcarlson5
Copy link
Member

Description

When a set cmd checks to see if the config is valid it will now also make sure if it is a query level config for gen 2 queries

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@wcarlson5 wcarlson5 requested a review from a team as a code owner February 4, 2022 00:18
@wcarlson5 wcarlson5 merged commit d8ff588 into confluentinc:master Feb 4, 2022
@wcarlson5 wcarlson5 deleted the check_configs_server_side branch February 4, 2022 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants