Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add BYTES support for KAFKA format #9180

Merged
merged 7 commits into from Jun 13, 2022
Merged

fix: add BYTES support for KAFKA format #9180

merged 7 commits into from Jun 13, 2022

Conversation

nateab
Copy link
Member

@nateab nateab commented Jun 7, 2022

Description

Fixes #8693 by adding ByteBuffer serdes to the KafkaSerdeFactory. Added a new QTT to the bytes.json to check correct behaviour for the KAFKA format.

Copy link
Contributor

@jzaralim jzaralim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix @nateab

@nateab nateab merged commit 844d275 into master Jun 13, 2022
@nateab nateab deleted the kafka-bytes branch June 13, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KAFKA format does not support BYTES
2 participants