Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove AVRO_SCHEMA_ID & SCHEMA_ID from QTT historical plans #9389

Merged

Conversation

spena
Copy link
Member

@spena spena commented Aug 4, 2022

Description

What behavior do you want to change, why, how does your patch achieve the changes?
These two configs were removed from KSQL and are causing exceptions in QTT. QTT tests do not fail. These exceptions are ignored. They're just adding noise to the tests output.

AVRO_SCHEMA_ID and SCHEMA_ID were removed here #4690

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

These two configs were removed from KSQL and are causing exceptions in QTT.
QTT tests do not fail. These exceptions are ignored. They're just adding
noise to the tests output.
@spena spena requested a review from a team as a code owner August 4, 2022 22:19
Copy link
Member

@pgaref pgaref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spena spena merged commit 4893d82 into confluentinc:master Aug 5, 2022
@spena spena deleted the clean_historical_plans_avro_schema_id branch August 5, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants