From e8b1c06a52097bf3e6e743e9e5c4e31da71933ac Mon Sep 17 00:00:00 2001 From: Magnus Edenhill Date: Tue, 13 Aug 2019 10:20:17 +0200 Subject: [PATCH] Optimization: avoid atomic fatal error code check when not idempotent. --- src/rdkafka_int.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/rdkafka_int.h b/src/rdkafka_int.h index 28a044f90..2c10c6aeb 100644 --- a/src/rdkafka_int.h +++ b/src/rdkafka_int.h @@ -637,7 +637,8 @@ int rd_kafka_set_fatal_error (rd_kafka_t *rk, rd_kafka_resp_err_t err, static RD_INLINE RD_UNUSED rd_kafka_resp_err_t rd_kafka_fatal_error_code (rd_kafka_t *rk) { - return rd_atomic32_get(&rk->rk_fatal.err); + return rk->rk_conf.eos.idempotence && + rd_atomic32_get(&rk->rk_fatal.err); }