Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jackson databind version override #148

Merged
merged 1 commit into from Jul 24, 2019

Conversation

@arvindth
Copy link
Member

commented Jul 22, 2019

Remove jackson databind version override
  - This should get inherited from the common pom
@ConfluentCLABot

This comment has been minimized.

Copy link

commented Jul 22, 2019

It looks like @arvindth hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@arvindth arvindth requested review from ewencp and xiangxin72 Jul 23, 2019

@@ -125,11 +125,6 @@
<artifactId>jetty-jaas</artifactId>
<version>${jetty.version}</version>
</dependency>
<dependency>

This comment has been minimized.

Copy link
@ewencp

ewencp Jul 23, 2019

Member

presumably we still want the dependency, just not override the version?

This comment has been minimized.

Copy link
@arvindth

arvindth Jul 23, 2019

Author Member

Actually we do want to remove the entire dependency here in the dependencymanagement section of the repo pom. Otherwise the dependency specified in the common pom gets overridden. The core submodule's pom still references the jackson-databind dependency, and inherits correctly from the common pom.

This comment has been minimized.

Copy link
@ewencp

ewencp Jul 24, 2019

Member

ah, i missed that this was in dependencyManagement, I thought it was in dependencies.

@ewencp
ewencp approved these changes Jul 24, 2019
Copy link
Member

left a comment

LGTM

@@ -125,11 +125,6 @@
<artifactId>jetty-jaas</artifactId>
<version>${jetty.version}</version>
</dependency>
<dependency>

This comment has been minimized.

Copy link
@ewencp

ewencp Jul 24, 2019

Member

ah, i missed that this was in dependencyManagement, I thought it was in dependencies.

@arvindth arvindth merged commit 5f39769 into confluentinc:3.3.x Jul 24, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@arvindth arvindth deleted the arvindth:ath-upgrade-jackson-2.9.9.1 branch Jul 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.