New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support basic auth credentials embedded in the schema.registry.url #507

Merged
merged 1 commit into from Nov 3, 2017

Conversation

Projects
None yet
7 participants
@Ormod

Ormod commented Mar 15, 2017

This is a rebase of the change in PR #418 . Some variables were renamed since the original PR which caused the merge conflict.

I contacted the original patch author and we agreed that I'll fix the conflict and resend the patch in a new PR. I also left the original author as the git commit author since I only did minor tweaking. According to the original author they've been using this successfully since the original PR was issued.

@ConfluentJenkins

This comment has been minimized.

Show comment
Hide comment
@ConfluentJenkins

ConfluentJenkins Mar 15, 2017

Contributor

Can one of the admins verify this patch?

Contributor

ConfluentJenkins commented Mar 15, 2017

Can one of the admins verify this patch?

@ConfluentCLABot

This comment has been minimized.

Show comment
Hide comment
@ConfluentCLABot

ConfluentCLABot Mar 15, 2017

It looks like @Ormod hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

ConfluentCLABot commented Mar 15, 2017

It looks like @Ormod hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@Ormod

This comment has been minimized.

Show comment
Hide comment
@Ormod

Ormod Apr 18, 2017

[clabot:check]

Ormod commented Apr 18, 2017

[clabot:check]

@ConfluentCLABot

This comment has been minimized.

Show comment
Hide comment
@ConfluentCLABot

ConfluentCLABot Apr 18, 2017

@confluentinc It looks like @Ormod just signed our Contributor License Agreement. 👍

Always at your service,

clabot

ConfluentCLABot commented Apr 18, 2017

@confluentinc It looks like @Ormod just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@ewencp

This comment has been minimized.

Show comment
Hide comment
@ewencp

ewencp Apr 18, 2017

Member

ok to test

Member

ewencp commented Apr 18, 2017

ok to test

@ewencp

@Ormod Thanks for the patch!

There's one trivial checkstyle nit. Checkstyle is also starting to complain about the complexity of this method. Perhaps we can refactor this chunk out into a separate helper method to keep the complexity down (and it looks like we should think about a bit of additional refactoring later as the complexity is just on the edge).

(Note that you may need to merge with master to see these failures locally -- the PR builder tests the merge commit which is why it fails differently than testing directly against your branch.)

@Ormod

This comment has been minimized.

Show comment
Hide comment
@Ormod

Ormod May 28, 2017

Fixed the trivial checkstyle nit. (missing space in the if clause)

Ormod commented May 28, 2017

Fixed the trivial checkstyle nit. (missing space in the if clause)

@tboldt

This comment has been minimized.

Show comment
Hide comment
@tboldt

tboldt Jun 15, 2017

Contributor

[clabot:check]

Contributor

tboldt commented Jun 15, 2017

[clabot:check]

@ConfluentCLABot

This comment has been minimized.

Show comment
Hide comment
@ConfluentCLABot

ConfluentCLABot Jun 15, 2017

@confluentinc It looks like @Ormod just signed our Contributor License Agreement. 👍

Always at your service,

clabot

ConfluentCLABot commented Jun 15, 2017

@confluentinc It looks like @Ormod just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@ConfluentJenkins

This comment has been minimized.

Show comment
Hide comment
@ConfluentJenkins

ConfluentJenkins Jun 15, 2017

Contributor

Can one of the admins verify this patch?

Contributor

ConfluentJenkins commented Jun 15, 2017

Can one of the admins verify this patch?

@tboldt

This comment has been minimized.

Show comment
Hide comment
@tboldt

tboldt Jun 15, 2017

Contributor

I have a fix for the method complexity issue. I think I need to create a separate pull request to prove that I have signed the contributor agreement.

Contributor

tboldt commented Jun 15, 2017

I have a fix for the method complexity issue. I think I need to create a separate pull request to prove that I have signed the contributor agreement.

@tboldt

This comment has been minimized.

Show comment
Hide comment
@tboldt

tboldt Jun 26, 2017

Contributor

@ewencp I created pull request #571 to fix the method complexity issue.

Contributor

tboldt commented Jun 26, 2017

@ewencp I created pull request #571 to fix the method complexity issue.

@mageshn mageshn merged commit 789621d into confluentinc:master Nov 3, 2017

1 check failed

default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment