Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Support basic auth credentials embedded in the schema.registry.url #507
This is a rebase of the change in PR #418 . Some variables were renamed since the original PR which caused the merge conflict.
I contacted the original patch author and we agreed that I'll fix the conflict and resend the patch in a new PR. I also left the original author as the git commit author since I only did minor tweaking. According to the original author they've been using this successfully since the original PR was issued.
It looks like @Ormod hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here.
Once you've signed reply with
Appreciation of efforts,
@Ormod Thanks for the patch!
There's one trivial checkstyle nit. Checkstyle is also starting to complain about the complexity of this method. Perhaps we can refactor this chunk out into a separate helper method to keep the complexity down (and it looks like we should think about a bit of additional refactoring later as the complexity is just on the edge).
(Note that you may need to merge with master to see these failures locally -- the PR builder tests the merge commit which is why it fails differently than testing directly against your branch.)