New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CC-3635 - Add config to specify location of static resources #992

Merged
merged 2 commits into from Jan 14, 2019

Conversation

Projects
None yet
3 participants
@rayokota
Copy link
Member

rayokota commented Jan 12, 2019

Add a Schema Registry config to specify the location of static resources. This is to allow a resource extension to provide a web interface if desired.

@rayokota rayokota requested a review from confluentinc/connect Jan 14, 2019

@wicknicks
Copy link
Contributor

wicknicks left a comment

couple of nits, otherwise LGTM.

protected ResourceCollection getStaticResources() {
List<String> locations = config.getStaticLocations();
if (locations != null && !locations.isEmpty()) {
Resource[] resources = config.getStaticLocations().stream()

This comment has been minimized.

@wicknicks

wicknicks Jan 14, 2019

Contributor

locations.stream()?

.toArray(Resource[]::new);
return new ResourceCollection(resources);
} else {
return null;

This comment has been minimized.

@wicknicks

wicknicks Jan 14, 2019

Contributor

should this be super.getStaticResources() instead?

@wicknicks
Copy link
Contributor

wicknicks left a comment

LGTM.

@rayokota rayokota merged commit 034cfd2 into confluentinc:master Jan 14, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@rayokota rayokota deleted the rayokota:CC-3635 branch Jan 14, 2019

@mageshn

This comment has been minimized.

Copy link
Member

mageshn commented Jan 14, 2019

A little late to comment but would something like this be a better fit in rest-utils?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment