CC-3635 - Add config to specify location of static resources #992
Conversation
|
couple of nits, otherwise LGTM. |
core/src/main/java/io/confluent/kafka/schemaregistry/rest/SchemaRegistryRestApplication.java
Outdated
| protected ResourceCollection getStaticResources() { | ||
| List<String> locations = config.getStaticLocations(); | ||
| if (locations != null && !locations.isEmpty()) { | ||
| Resource[] resources = config.getStaticLocations().stream() |
wicknicks
Jan 14, 2019
Contributor
locations.stream()?
locations.stream()?
core/src/main/java/io/confluent/kafka/schemaregistry/rest/SchemaRegistryRestApplication.java
Outdated
| .toArray(Resource[]::new); | ||
| return new ResourceCollection(resources); | ||
| } else { | ||
| return null; |
wicknicks
Jan 14, 2019
Contributor
should this be super.getStaticResources() instead?
should this be super.getStaticResources() instead?
|
LGTM. |
|
A little late to comment but would something like this be a better fit in rest-utils? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Add a Schema Registry config to specify the location of static resources. This is to allow a resource extension to provide a web interface if desired.