Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upCC-3635 - Add config to specify location of static resources #992
Conversation
rayokota
requested a review
from confluentinc/connect
Jan 14, 2019
core/src/main/java/io/confluent/kafka/schemaregistry/rest/SchemaRegistryRestApplication.java
Outdated
| protected ResourceCollection getStaticResources() { | ||
| List<String> locations = config.getStaticLocations(); | ||
| if (locations != null && !locations.isEmpty()) { | ||
| Resource[] resources = config.getStaticLocations().stream() |
This comment has been minimized.
This comment has been minimized.
core/src/main/java/io/confluent/kafka/schemaregistry/rest/SchemaRegistryRestApplication.java
Outdated
| .toArray(Resource[]::new); | ||
| return new ResourceCollection(resources); | ||
| } else { | ||
| return null; |
This comment has been minimized.
This comment has been minimized.
rayokota
merged commit 034cfd2
into
confluentinc:master
Jan 14, 2019
1 check passed
continuous-integration/jenkins/pr-merge
This commit looks good
Details
rayokota
deleted the
rayokota:CC-3635
branch
Jan 14, 2019
This comment has been minimized.
This comment has been minimized.
|
A little late to comment but would something like this be a better fit in rest-utils? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
rayokota commentedJan 12, 2019
Add a Schema Registry config to specify the location of static resources. This is to allow a resource extension to provide a web interface if desired.