New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import an album from Flickr as a redirect #177

Closed
japsu opened this Issue Jan 9, 2019 · 2 comments

Comments

Projects
None yet
1 participant
@japsu
Copy link
Member

japsu commented Jan 9, 2019

A photographer wants to be featured at the site but does not want to upload their photos to the site. Instead, they want to host their photos at Flickr or some other external site.

  • Figure a way to add these as "redirect albums" so that they show up in the listing but clicking them opens the album instead in a new window.
    • If an album has redirect_url, it's called a "link album".
    • If such an album is a visible subalbum of another album, it will be displayed with a redirect icon.
    • Selecting said subalbum will open the redirect_url in another browser window.
    • When adding a link album, one picture should be uploaded to it to give it a cover picture.
  • When creating link albums that link to popular services (such as Flickr), a thumbnail image should be extracted automatically. Possible sources include service specific APIs and HTML <meta> values, such as <meta name="og:image">.
  • The use of redirect_url is not consistent now. This should be fixed. See comment.

@japsu japsu added the enhancement label Jan 9, 2019

@japsu

This comment has been minimized.

Copy link
Member

japsu commented Jan 10, 2019

Initial support for this done, see example at larppikuvat.fi.

The use of the redirect_url field is not very consistent now:

  • Navigating to an album with a redirect_uri to an internal path like /fooalbum will trigger an internal redirect in the frontend and open the referenced album instead
    • This was the original use case of redirect_uri.
    • It should be used when you want to change the slug of an album without breaking links to said album: change the slug of the original album and create a hidden "redirect album" in its place.
  • ⚠️Navigating to an album with a redirect_uri to an off-site URL like https://kompassi.eu will probably barf.
  • 🤔Viewing an album that has a subalbum with a redirect_uri opens that URL in another window. As intended for external URLs, but internal paths here don't really make sense.

@japsu japsu self-assigned this Jan 10, 2019

@japsu

This comment has been minimized.

Copy link
Member

japsu commented Jan 16, 2019

Promoting bullet 3 as an issue of its own and closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment