This repository has been archived by the owner on Apr 12, 2021. It is now read-only.
after-input doesnt run on steps with no viewable additional-input metadata #1364
Comments
Log without
Grep'd for steps, see there is no mention of
|
Log with my nonsensical metadata added:
Grep'd for steps, see my
|
johnsca
added a commit
that referenced
this issue
Mar 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What I'm trying to do
Create a cdk spell that will use
bundle-add
in anafter-input
step to reconfigure thekubernetes-worker
stanza to set GPU constraints (instance-type=pX
).What I did
Be me, on Darwin:
Attempt to include an
after-input
step (chmod'd 0755):https://github.com/juju-solutions/spells/tree/feature/cdk-nvidia/canonical-kubernetes-nvidia/steps/00_process-providertype
Note that this step doesn't have
viewable: True
noradditional-input
fields:https://github.com/juju-solutions/spells/blob/feature/cdk-nvidia/canonical-kubernetes-nvidia/steps/00_process-providertype/metadata.yaml
Use a local spell dir with the above forked repo on the
feature/cdk-nvidia
branch with:Select CDK+GPU, no addons, AWS, and the default flannel choice. Notice the debug output does not say anything about running
canonical-kubernetes-nvidia/steps/00_process-providertype/after-input
.What I want
conjure-up to execute
after-input
even if there's no viewable additional input defined in the step metadata.What I got
conjure-up did not execute my
after-input
script.Colorful commentary
I tried quite a few permutations on the
00_process-providertype
step. The only way I could get myafter-input
script to execute was to includeviewable: True
and an unused input into that step metadata:I could not get it to run without both
viewable
andadditional-input
. Including these is most unfortunate because I don't actually want the user to see thisNOTUSED
key.The text was updated successfully, but these errors were encountered: