Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Allow specifying model name in headless #635
Comments
battlemidget
self-assigned this
Jan 30, 2017
battlemidget
added this to the 2.1.0 milestone
Jan 30, 2017
battlemidget
added
the
enhancement
label
Jan 30, 2017
battlemidget
referenced this issue
Jan 30, 2017
Closed
add ability to customize model name in UI #637
added a commit
that referenced
this issue
Jan 30, 2017
battlemidget
modified the milestones:
2.1.0,
2.1.1
Jan 30, 2017
battlemidget
changed the title from
Allow specifying model name in headless and possibly in gui?
to
Allow specifying model name in headless
Jan 30, 2017
|
I think the main concern here might have already been addressed by the changes in #619 , right? The problem @marcoceppi pointed out was "model names that don't represent what the deployment is", and while allowing the user to set them is one way to fix that, isn't automatically generating meaningful names solving the same problem without requiring the user to do more? |
|
I think @marcoceppi was more concerned with providing his own names for the models to represent the different phases of the application(s) deployed. |
battlemidget
modified the milestones:
later,
2.1.0
Feb 6, 2017
|
We decided to stick with the recent changes that name the controllers/models relevant to whats being deployed. |
battlemidget
closed this
Feb 8, 2017
marcoceppi
commented
Feb 8, 2017
|
Doesn't resolve this bug.
…
|
|
@marcoceppi can you elaborate? I thought it solved your problem. |
mikemccracken
reopened this
Feb 8, 2017
marcoceppi
commented
Feb 8, 2017
|
I would like to name my models in headless. Repeating 2 kubernetes core
deployments, let alone 5, mean I have models that are names
conjure-up-kubernetes-core-xxxx which is meaningless for me.
…
|
|
ok, thanks for clarifying
On Wed, Feb 8, 2017 at 12:10 PM, Marco Ceppi <notifications@github.com>
wrote:
…
|
battlemidget
modified the milestones:
2.1.0,
later
Feb 9, 2017
battlemidget
closed this
in
#638
Feb 9, 2017
added a commit
that referenced
this issue
Feb 9, 2017
marcoceppi
commented
Feb 9, 2017
|
Documentation would need to be updated, but thank you! |
marcoceppi commentedJan 30, 2017
We're using something like the following in headless:
But this creates model names that don't represent what the deployment is. Suggestion to allow a third positional argument to set model name:
Alternatively, it might be interesting to implicitly set the model name in the UI above the deploy screen as a prefilled but editable "Deployment name" to expose this functionality in the UI. I'm hesitant to put it there, choice fatigue, etc.