Allow specifying model name in headless #635

Closed
marcoceppi opened this Issue Jan 30, 2017 · 8 comments

Comments

Projects
None yet
3 participants

We're using something like the following in headless:

conjure-up kubernetes-core localhost my-controller
conjure-up kubernetes-core localhost my-controller

But this creates model names that don't represent what the deployment is. Suggestion to allow a third positional argument to set model name:

conjure-up kubernetes-core localhost my-controller prod-test
conjure-up kubernetes-core localhost my-controller qa-cluster

Alternatively, it might be interesting to implicitly set the model name in the UI above the deploy screen as a prefilled but editable "Deployment name" to expose this functionality in the UI. I'm hesitant to put it there, choice fatigue, etc.

@battlemidget battlemidget self-assigned this Jan 30, 2017

@battlemidget battlemidget added this to the 2.1.0 milestone Jan 30, 2017

battlemidget added a commit that referenced this issue Jan 30, 2017

Allow specifying model in headless mode
Fixes #635

Signed-off-by: Adam Stokes <battlemidget@users.noreply.github.com>

@battlemidget battlemidget modified the milestones: 2.1.0, 2.1.1 Jan 30, 2017

@battlemidget battlemidget changed the title from Allow specifying model name in headless and possibly in gui? to Allow specifying model name in headless Jan 30, 2017

Contributor

mikemccracken commented Jan 30, 2017

I think the main concern here might have already been addressed by the changes in #619 , right?

The problem @marcoceppi pointed out was "model names that don't represent what the deployment is", and while allowing the user to set them is one way to fix that, isn't automatically generating meaningful names solving the same problem without requiring the user to do more?

Contributor

battlemidget commented Jan 30, 2017

I think @marcoceppi was more concerned with providing his own names for the models to represent the different phases of the application(s) deployed.

@battlemidget battlemidget modified the milestones: later, 2.1.0 Feb 6, 2017

Contributor

battlemidget commented Feb 8, 2017

We decided to stick with the recent changes that name the controllers/models relevant to whats being deployed.

Contributor

mikemccracken commented Feb 8, 2017

@marcoceppi can you elaborate? I thought it solved your problem.

@mikemccracken mikemccracken reopened this Feb 8, 2017

Contributor

mikemccracken commented Feb 8, 2017

@battlemidget battlemidget modified the milestones: 2.1.0, later Feb 9, 2017

@battlemidget battlemidget closed this in #638 Feb 9, 2017

battlemidget added a commit that referenced this issue Feb 9, 2017

Allow specifying model in headless mode (#638)
Fixes #635

Signed-off-by: Adam Stokes <battlemidget@users.noreply.github.com>

Documentation would need to be updated, but thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment