Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fix JAAS registration for 2.2-beta4 #879
Conversation
|
This is blocked on juju/python-libjuju#124 but shouldn't require any further changes once that is fixed. |
battlemidget
self-requested a review
May 10, 2017
| stdout, stderr = await asyncio.wait_for(proc.communicate(stdin), | ||
| timeout) | ||
| stdout = stdout.decode('utf8') | ||
| stderr = stderr.decode('utf8') | ||
| + | ||
| + prefix = 'Enter a name for this controller: ' |
battlemidget
May 10, 2017
Contributor
Do we provide any input for this or is it just us reading that prefix?
johnsca
May 10, 2017
Collaborator
We provide input for it, but Juju has started putting the prompt for it on stderr instead of stdout. All of the other prompts go on stdout like they should. We should probably file a bug, but it doesn't seem like it'd be high priority and the work-around isn't terrible.
|
libjuju 0.4.2 has been released to pypi with the other part of the fix for this. |
johnsca
merged commit 6e301f2
into
master
May 10, 2017
battlemidget
deleted the
bug/878-per-controller-macaroons
branch
Jun 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
johnsca commentedMay 10, 2017
Juju 2.2-beta4 switched to per-controller macaroon files.
Fixes #878