Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Remove the kibana spell steps as it was removed from CDK bundle #23
Conversation
battlemidget
self-assigned this
Dec 16, 2016
| @@ -16,10 +16,3 @@ fi | ||
| NODES="$(~/kubectl $args get nodes | perl -p -e 's/\n/\\n/')" | ||
| PODS="$(~/kubectl $args get --all-namespaces pods | perl -p -e 's/\n/\\n/')" | ||
| SERVICES="$(~/kubectl $args get --all-namespaces services | perl -p -e 's/\n/\\n/')" | ||
| - | ||
| -juju expose kibana |
| - | ||
| -juju expose kibana | ||
| - | ||
| -KIBANA_ADDR=$(unitAddress kibana 0) |
| -juju expose kibana | ||
| - | ||
| -KIBANA_ADDR=$(unitAddress kibana 0) | ||
| -result="Nodes:\n$NODES\nPods:\n$PODS\nServices:\n$SERVICES\n\nView Kibana at http://$KIBANA_ADDR/" |
battlemidget
Dec 16, 2016
Contributor
Let's keep this line but remove \n\nView Kibana at http://$KIBANA_ADDR/
chuckbutler
Dec 16, 2016
Contributor
Ok, Should I also leave the exposeResult line below?
exposeResult just prints to the summary screen at the end of conjure-up
|
OK, i gave this a forced update after reverting the big deletion. Give this another peek and make sure this still lines up with what you'd expect to see Thanks for the quick review |
battlemidget
merged commit ff3b754
into
conjure-up:master
Dec 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
chuckbutler commentedDec 16, 2016
•
Edited 1 time
-
chuckbutler
Dec 16, 2016
During the 1.5.1 release cycle it was determined we should strip the monitoring
stack from kubernetes, and offer them as a separate bundle permutation or
addon bundle with inheritance. This left a notice in conjure-up where kibana
was null.
This removes the kibana expose and http://null/ url for accessing kibana
Original request was documented over in juju-solutions/bundle-canonical-kubernetes#138