Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Issue #42 fixes. #55

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants

mjwood7 commented Mar 26, 2012

Fixes for issue #42. Usage of System.Environment.TickCount has been replaced with DateTime milliseconds.

Member

gbirchmeier commented Mar 27, 2012

Thanks, Matt. I'll try to have a look at it today.

Member

gbirchmeier commented Mar 30, 2012

Apologies for the delay. I've spent two days recovering from a HD crash on my primary machine. I plan to look at this over the weekend.

mjwood7 commented Mar 30, 2012

No problem... sorry to hear about the crash.

Member

gbirchmeier commented Apr 4, 2012

This did not build for me. Did build the UnitTests project? I'm getting lots of compile failures in SessionStateTest.cs.

mjwood7 commented Apr 4, 2012

I didn't do anything with the UnitTests project. I'll have to look into it.

Member

gbirchmeier commented Apr 4, 2012

The entire solution must build, and all applicable tests must be adjusted/corrected or removed with reason. Depending on the fix, the addition of new tests may be appropriate.

We're very big on using using tests to prevent against accidental breakage of features.

Member

gbirchmeier commented Apr 4, 2012

Can you use DateTime.UtcNow instead of DateTime.Now?

Member

gbirchmeier commented Apr 23, 2012

Submission does not build as part of whole solution. (Unit test project is broken.) We cannot accept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment