Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable Android instrumentation tests #407

Merged
merged 4 commits into from May 31, 2016

Conversation

kruton
Copy link
Member

@kruton kruton commented May 31, 2016

The Android instrumentation tests were disabled to check in the new host editor. Since it's been checked in, we can rewrite the tests to use the new layouts.

The change to red test shows there is a bug in the editor fragment.
If we are focused on an EditText and click on a virtual "Spinner" then
we should hide the keyboard to make sure the back key works as expected.

Since this is fixed, we can re-enable the tests for this.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 4.034% when pulling 26d3436 on kruton:reenable-mockito-tests into 528bfc1 on connectbot:master.

@kruton kruton force-pushed the reenable-mockito-tests branch 3 times, most recently from 768e968 to 26d3436 Compare May 31, 2016 07:06
@kruton kruton merged commit 77ccf39 into connectbot:master May 31, 2016
@kruton kruton deleted the reenable-mockito-tests branch May 31, 2016 07:29
galexander1 pushed a commit to galexander1/connectbot that referenced this pull request Dec 10, 2016
galexander1 pushed a commit to galexander1/connectbot that referenced this pull request Dec 10, 2016
This reverts commit a591a30, reversing
changes made to 0bb22e9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants