Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance/Jump Links #106

Merged
merged 3 commits into from Jan 31, 2019
Merged

Enhance/Jump Links #106

merged 3 commits into from Jan 31, 2019

Conversation

jwithington
Copy link
Contributor

Adds permalinks to examples, as requested here.

Could be prettier, maybe? This is a good simple start, however. 馃榾

Copy link
Member

@drolsen drolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Thank you @jwithington
Few small changes I think would really bring this feature to life!

  1. Lets wrap the link around our heading vs. making them siblings. This way the entire heading is a click area to grab a jump link from.
  2. Lets add a new chain link icon https://filebin.net/dmkfc6sbjtam4uvn to atoms/icon/assets and add a hover rule/:before pseudo for the heading so that when hovered a link icon appears before the heading text. This will give visual indication to the end user they can grab a link by clicking this area.

@drolsen drolsen merged commit 6e93478 into dev Jan 31, 2019
@drolsen drolsen deleted the Enhance/JumpLinks branch January 31, 2019 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants