From ce5a0ec63762d746f9ed80b0b545936a24188e1c Mon Sep 17 00:00:00 2001 From: Joshua Humphries <2035234+jhump@users.noreply.github.com> Date: Fri, 22 Mar 2024 11:30:22 -0400 Subject: [PATCH] Re-enable buf breaking in CI (#838) --- .github/workflows/buf.yaml | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/.github/workflows/buf.yaml b/.github/workflows/buf.yaml index 4942733a..026db3bf 100644 --- a/.github/workflows/buf.yaml +++ b/.github/workflows/buf.yaml @@ -21,15 +21,10 @@ jobs: steps: - uses: actions/checkout@v4 - uses: bufbuild/buf-setup-action@v1 - # TODO: this change is technically wire- and json-compatible - # but "buf breaking"'s checks are too strict and disallow - # renaming messages :( - # So we have to disable this check for this change and - # must re-enable ASAP after this change is merged. -# - uses: bufbuild/buf-breaking-action@v1.1.3 -# with: -# input: proto -# against: 'buf.build/connectrpc/conformance' + - uses: bufbuild/buf-breaking-action@v1.1.3 + with: + input: proto + against: 'buf.build/connectrpc/conformance' push: runs-on: ubuntu-latest if: github.ref == 'refs/heads/main'