Skip to content

Add Sendable conformance to generated clients #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add Sendable conformance to generated clients #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Examples/ElizaSharedSources/GeneratedSources/eliza.connect.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ internal protocol Buf_Connect_Demo_Eliza_V1_ElizaServiceClientInterface {
}

/// Concrete implementation of `Buf_Connect_Demo_Eliza_V1_ElizaServiceClientInterface`.
internal final class Buf_Connect_Demo_Eliza_V1_ElizaServiceClient: Buf_Connect_Demo_Eliza_V1_ElizaServiceClientInterface {
internal final class Buf_Connect_Demo_Eliza_V1_ElizaServiceClient: Buf_Connect_Demo_Eliza_V1_ElizaServiceClientInterface, Sendable {
private let client: Connect.ProtocolClientInterface

internal init(client: Connect.ProtocolClientInterface) {
Expand Down
4 changes: 3 additions & 1 deletion Plugins/ConnectSwiftPlugin/ConnectClientGenerator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,9 @@ final class ConnectClientGenerator: Generator {

let className = service.implementationName(using: self.namer)
self.printLine("/// Concrete implementation of `\(protocolName)`.")
self.printLine("\(self.visibility) final class \(className): \(protocolName) {")
self.printLine(
"\(self.visibility) final class \(className): \(protocolName), Sendable {"
)
self.indent {
self.printLine("private let client: Connect.ProtocolClientInterface")
self.printLine()
Expand Down
12 changes: 6 additions & 6 deletions Tests/ConnectLibraryTests/Generated/grpc/testing/test.connect.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ internal protocol Grpc_Testing_TestServiceClientInterface {
}

/// Concrete implementation of `Grpc_Testing_TestServiceClientInterface`.
internal final class Grpc_Testing_TestServiceClient: Grpc_Testing_TestServiceClientInterface {
internal final class Grpc_Testing_TestServiceClient: Grpc_Testing_TestServiceClientInterface, Sendable {
private let client: Connect.ProtocolClientInterface

internal init(client: Connect.ProtocolClientInterface) {
Expand Down Expand Up @@ -266,7 +266,7 @@ internal protocol Grpc_Testing_UnimplementedServiceClientInterface {
}

/// Concrete implementation of `Grpc_Testing_UnimplementedServiceClientInterface`.
internal final class Grpc_Testing_UnimplementedServiceClient: Grpc_Testing_UnimplementedServiceClientInterface {
internal final class Grpc_Testing_UnimplementedServiceClient: Grpc_Testing_UnimplementedServiceClientInterface, Sendable {
private let client: Connect.ProtocolClientInterface

internal init(client: Connect.ProtocolClientInterface) {
Expand Down Expand Up @@ -317,7 +317,7 @@ internal protocol Grpc_Testing_ReconnectServiceClientInterface {
}

/// Concrete implementation of `Grpc_Testing_ReconnectServiceClientInterface`.
internal final class Grpc_Testing_ReconnectServiceClient: Grpc_Testing_ReconnectServiceClientInterface {
internal final class Grpc_Testing_ReconnectServiceClient: Grpc_Testing_ReconnectServiceClientInterface, Sendable {
private let client: Connect.ProtocolClientInterface

internal init(client: Connect.ProtocolClientInterface) {
Expand Down Expand Up @@ -373,7 +373,7 @@ internal protocol Grpc_Testing_LoadBalancerStatsServiceClientInterface {
}

/// Concrete implementation of `Grpc_Testing_LoadBalancerStatsServiceClientInterface`.
internal final class Grpc_Testing_LoadBalancerStatsServiceClient: Grpc_Testing_LoadBalancerStatsServiceClientInterface {
internal final class Grpc_Testing_LoadBalancerStatsServiceClient: Grpc_Testing_LoadBalancerStatsServiceClientInterface, Sendable {
private let client: Connect.ProtocolClientInterface

internal init(client: Connect.ProtocolClientInterface) {
Expand Down Expand Up @@ -425,7 +425,7 @@ internal protocol Grpc_Testing_XdsUpdateHealthServiceClientInterface {
}

/// Concrete implementation of `Grpc_Testing_XdsUpdateHealthServiceClientInterface`.
internal final class Grpc_Testing_XdsUpdateHealthServiceClient: Grpc_Testing_XdsUpdateHealthServiceClientInterface {
internal final class Grpc_Testing_XdsUpdateHealthServiceClient: Grpc_Testing_XdsUpdateHealthServiceClientInterface, Sendable {
private let client: Connect.ProtocolClientInterface

internal init(client: Connect.ProtocolClientInterface) {
Expand Down Expand Up @@ -473,7 +473,7 @@ internal protocol Grpc_Testing_XdsUpdateClientConfigureServiceClientInterface {
}

/// Concrete implementation of `Grpc_Testing_XdsUpdateClientConfigureServiceClientInterface`.
internal final class Grpc_Testing_XdsUpdateClientConfigureServiceClient: Grpc_Testing_XdsUpdateClientConfigureServiceClientInterface {
internal final class Grpc_Testing_XdsUpdateClientConfigureServiceClient: Grpc_Testing_XdsUpdateClientConfigureServiceClientInterface, Sendable {
private let client: Connect.ProtocolClientInterface

internal init(client: Connect.ProtocolClientInterface) {
Expand Down