Fix (some) path issues. #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connertennery
reviewed
Oct 13, 2020
@zeyus I made a few changes on top of your pull request. After a little more testing, I'll merge it in.
|
@connertennery had issues with converter on mac OS, merging these fixes by @zeyus manually in my local copy did the job for me. Fix is ready to merge from my experience. |
|
@benjaminharr Thank you for testing. Been really busy with work and I meant to test this on Linux but I haven't had the time. I'll merge it in now. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is just a quick fix, I found that some of the paths didn't work, this fixes some of the issues, and by using the
npath.sepit should be platform independent.