Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(list): implement bullet list style #239

Merged
merged 17 commits into from
Apr 21, 2020
Merged

Conversation

connium
Copy link
Owner

@connium connium commented Apr 20, 2020

What kind of change is this PR?

feature

What is the current behavior?

Lists cannot be styled which means the default style of the reader will be applied.

What is the new behavior (if this is a feature change)?

With this change it is possible to define the style of bullet lists (such as indentation and bullet character). Up to 10 levels are supported.

Does this PR introduce a breaking change?

no

Please check if the PR fulfills these requirements

  • Changelog has been updated
  • Fix/Feature: JSDocs have been added/updated
  • Fix/Feature: Tests have been added; existing tests pass

@connium connium added the enhancement New feature or request label Apr 20, 2020
@connium connium added this to the 0.11.0 milestone Apr 20, 2020
@connium connium self-assigned this Apr 20, 2020
@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@38aaaf8). Click here to learn what that means.
The diff coverage is 99.47%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #239   +/-   ##
=========================================
  Coverage          ?   98.06%           
=========================================
  Files             ?       64           
  Lines             ?     1552           
  Branches          ?      199           
=========================================
  Hits              ?     1522           
  Misses            ?       30           
  Partials          ?        0           
Impacted Files Coverage Δ
src/api/util/isNonNegativeNumber.ts 100.00% <ø> (ø)
src/api/util/isPercent.ts 100.00% <ø> (ø)
src/api/util/isPositiveLength.ts 100.00% <ø> (ø)
src/xml/office/TextPropertiesVisitor.ts 97.05% <97.05%> (ø)
src/api/office/AutomaticStyles.ts 98.59% <98.18%> (ø)
src/api/office/CommonStyles.ts 100.00% <100.00%> (ø)
src/api/style/BulletListLevelStyle.ts 100.00% <100.00%> (ø)
src/api/style/ListLevelProperties.ts 100.00% <100.00%> (ø)
src/api/style/ListStyle.ts 100.00% <100.00%> (ø)
src/api/style/ParagraphStyle.ts 84.12% <100.00%> (ø)
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38aaaf8...d5de86e. Read the comment docs.

@connium connium merged commit c9f6d4d into master Apr 21, 2020
@connium connium deleted the feat/list/implement-list-style branch April 21, 2020 05:02
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant