Starting template application - "Error: Cannot find module 'app'" #111

Open
polgarijog opened this Issue Jun 18, 2016 · 10 comments

Projects

None yet

7 participants

@polgarijog
  1. Downloaded "dist" zip
  2. Unzipped
  3. Opened terminal, cd to the folder "template-app"
  4. Run "electron ."
  5. Got an error: "Error: Cannot find module 'app'"

I've debuged in vs.code too, the first require("app") throws that exception.

Electron-prebuild is installed via npm/nvm.

What I'm doing wrong?

@scholtzm

Seems like you are using Electron v1.x and template app uses older version of Electron APIs.

@polgarijog

Thank you.

@polgarijog

Ah, one more question: do you have any idea how to fix/workaround it?

@gadget00

So far, you have to re-write the code of Photon so it complies with the new syntax of Electron 1.x

@scholtzm

You could also use older version of Electron, but I would advise against that.

@polgarijog

Oh, sad...thank you all!

@zephyrzoom

It also happend to me!

@arjunmenon

Spent more than an hour to finding out the cause. Was actually frustrating.
This seems like a common issue. Can the author put up a guide on re-writing the Photon to work with newer stable versions?

@sercheo87

The error is solvent with replace the next section in file app.js

var app = require('app'); // Module to control application life. var BrowserWindow = require('browser-window'); // Module to create native browser window.

with

const {app, BrowserWindow} = require('electron');

@samuelyeshua

#117 This was solved in this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment