Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement import command #34
In case of name conflicts this command will warn the user and will prefer the version in the storage over the version in the JSON.
Afterwards it prints number of added passwords.
1 I did some googling about that problem and found out that it's possible to prompt the user without accessing stdin. This is done by reading
Hi @yamnikov-oleg !
Thanks a lot for this. Looks good as far as I can see. I like how you reused the existing
Thanks again ! I'll keep you updated once I have compiled/tested locally.
@yamnikov-oleg Thanks again for this PR
Overall, this looks great but there are a few issues which I've commented.
Let me know if you have time to fix them:
- if you have time to fix them, yay!
- if you don't have the time, it's fine as well
😃just let me know, I will merge now and fix the issues later before the next release.
@conradkdotcom I have time to fix it, it's alright :)
So, I've replaced the
And when Rooster can't decode json:
There is still that low-level message about
By the way, it seems to me, there are other