Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy clippy linting #153

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Conversation

danieleades
Copy link
Contributor

  • add clippy config file aligned with MSRV set in CI
  • move deny warnings from the CI script to a compiler flag to ensure consistent behaviour during development and CI
  • address a few pedantic lints

Copy link
Collaborator

@pksunkara pksunkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want the clippy to be run on stable, not msrv.

@danieleades
Copy link
Contributor Author

danieleades commented Dec 5, 2021

We want the clippy to be run on stable, not msrv.

that's not what the clippy config does. setting the MSRV prevents clippy from suggesting changes that use syntax or features which are not compatible with the MSRV.

see https://github.com/rust-lang/rust-clippy#specifying-the-minimum-supported-rust-version

to add to that- if you use the msrv config option, there's no reason not to use nightly for clippy linting, rather than stable or MSRV

@pksunkara pksunkara merged commit 29da763 into console-rs:master Dec 6, 2021
@pksunkara
Copy link
Collaborator

Thanks! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants