New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New name for coveralls #666

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@szepeviktor
Contributor

szepeviktor commented Jan 2, 2018

php-coveralls

New name for coveralls
php-coveralls
@szepeviktor

This comment has been minimized.

Show comment
Hide comment
@szepeviktor

szepeviktor Jan 2, 2018

Contributor

Could it be that we do not Coveralls at all?

https://travis-ci.org/consolidation/Robo/jobs/324286322#L989

Contributor

szepeviktor commented Jan 2, 2018

Could it be that we do not Coveralls at all?

https://travis-ci.org/consolidation/Robo/jobs/324286322#L989

@greg-1-anderson

This comment has been minimized.

Show comment
Hide comment
@greg-1-anderson

greg-1-anderson Jan 2, 2018

Member

This used to work, although whether the failure was introduced by a change in Codeception or a change in the Robo build rules, I am not sure.

Member

greg-1-anderson commented Jan 2, 2018

This used to work, although whether the failure was introduced by a change in Codeception or a change in the Robo build rules, I am not sure.

@szepeviktor

This comment has been minimized.

Show comment
Hide comment
@szepeviktor

szepeviktor Jan 2, 2018

Contributor

I think the configuration xml file was removed.

Contributor

szepeviktor commented Jan 2, 2018

I think the configuration xml file was removed.

@szepeviktor

This comment has been minimized.

Show comment
Hide comment
@szepeviktor

szepeviktor Jan 2, 2018

Contributor

No, there was no XML: cb00bed

Contributor

szepeviktor commented Jan 2, 2018

No, there was no XML: cb00bed

@greg-1-anderson

This comment has been minimized.

Show comment
Hide comment
@greg-1-anderson

greg-1-anderson Jan 2, 2018

Member

I think it's okay to omit the configuration xml file; that's working in other projects:

https://travis-ci.org/consolidation/annotated-command/jobs/323953003#L648

Member

greg-1-anderson commented Jan 2, 2018

I think it's okay to omit the configuration xml file; that's working in other projects:

https://travis-ci.org/consolidation/annotated-command/jobs/323953003#L648

@greg-1-anderson

This comment has been minimized.

Show comment
Hide comment
@greg-1-anderson

greg-1-anderson Jan 2, 2018

Member

Looks like I broke coveralls when I updated to satooshi/php-coveralls:^2 and didn't notice that the collapsed build output for the coveralls run contained errors. Renaming the executable is required, seems that a config file might be required now, or some other change.

Member

greg-1-anderson commented Jan 2, 2018

Looks like I broke coveralls when I updated to satooshi/php-coveralls:^2 and didn't notice that the collapsed build output for the coveralls run contained errors. Renaming the executable is required, seems that a config file might be required now, or some other change.

@szepeviktor

This comment has been minimized.

Show comment
Hide comment
@szepeviktor

This comment has been minimized.

Show comment
Hide comment
@szepeviktor

szepeviktor Jan 2, 2018

Contributor

I leave it up to you!

Contributor

szepeviktor commented Jan 2, 2018

I leave it up to you!

@greg-1-anderson

This comment has been minimized.

Show comment
Hide comment
@greg-1-anderson

greg-1-anderson Jan 2, 2018

Member

Robo is using Codeception, which is built on top of phpunit, but perhaps calls it in such a way that phpunit.xml is not necessarily read or respected.

@DavertMik do you know what to do here?

Member

greg-1-anderson commented Jan 2, 2018

Robo is using Codeception, which is built on top of phpunit, but perhaps calls it in such a way that phpunit.xml is not necessarily read or respected.

@DavertMik do you know what to do here?

@szepeviktor

This comment has been minimized.

Show comment
Hide comment
@szepeviktor

szepeviktor Apr 23, 2018

Contributor

@DavertMik Could you help us?

Contributor

szepeviktor commented Apr 23, 2018

@DavertMik Could you help us?

@greg-1-anderson

This comment has been minimized.

Show comment
Hide comment
@greg-1-anderson

greg-1-anderson Apr 23, 2018

Member

Figured it out. Fixed and merged in #723

Member

greg-1-anderson commented Apr 23, 2018

Figured it out. Fixed and merged in #723

@szepeviktor szepeviktor deleted the szepeviktor:patch-2 branch Apr 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment