Skip to content

Conversation

@Teagan42
Copy link
Contributor

@Teagan42 Teagan42 commented Oct 6, 2025

What

  • pass keyword arguments to load_media and its invocation of run so IMDb queue paths and other options remain aligned
  • move require_positive into a shared mcp_plex.common.validation module and update callers to import it
  • add regression tests covering the CLI IMDb queue plumbing and the stricter require_positive behaviour

Why

  • prevent future regressions from positional argument mis-ordering in the loader
  • ensure value validation is shared and type-safe across packages

Affects

  • loader CLI orchestration
  • shared validation utilities
  • loader CLI and validation unit tests

Testing

  • uv run ruff check .
  • uv run pytest

Documentation

  • not needed

https://chatgpt.com/codex/tasks/task_e_68e36c699574832884007e8e56d9f919

@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
mcp_plex/loader
   __init__.py3881895%84–91, 165, 255–260, 621, 736–738, 740, 826–845, 1198
mcp_plex/loader/pipeline
   __init__.py16756%57–62, 68
   channels.py59297%20–21
   enrichment.py4316086%248, 253, 284, 286, 293, 297, 376, 397, 417, 425–427, 434–437, 440–442, 450, 507, 563, 586, 590, 592, 618, 636, 648, 677, 683, 686–694, 720, 723–725, 742–744, 764–767, 771, 785–791, 813, 815, 818–820
   ingestion.py81890%66, 97–107, 128, 156, 178
   orchestrator.py85594%48, 112, 141, 164–165
   persistence.py125993%112, 154–155, 165, 170, 174–176, 214
mcp_plex/server
   __init__.py6142995%43–44, 119–120, 148, 252, 256, 277–280, 297, 362, 365, 402, 420–421, 458, 1109, 1131–1137, 1173, 1191, 1196, 1214, 1338, 1375
   __main__.py440%3–8
   config.py48785%50, 52–55, 65, 76
TOTAL206214993% 

Tests Skipped Failures Errors Time
130 0 💤 0 ❌ 0 🔥 46.398s ⏱️

@Teagan42 Teagan42 merged commit c4bf55d into main Oct 6, 2025
4 checks passed
@Teagan42 Teagan42 deleted the codex/update-argument-passing-in-load_media branch October 6, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants