Skip to content

Conversation

@Teagan42
Copy link
Contributor

@Teagan42 Teagan42 commented Oct 7, 2025

What

  • log a warning and fall back to an empty store when the IMDb cache fails to decode JSON
  • add a regression test that asserts the warning is emitted for corrupt cache files
  • bump the project version to 1.0.10 and mirror the change in dependent manifests

Why

  • prevent silent cache resets from hiding corrupt cache files and make debugging loader issues easier

Affects

  • IMDb cache loader behavior and tests
  • project version metadata

Testing

  • uv run ruff check .
  • uv run pytest tests/test_imdb_cache.py

Documentation

  • No documentation updates needed

https://chatgpt.com/codex/tasks/task_e_68e45963eec08328905f9a8fdcf0d1fd

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@github-actions
Copy link

github-actions bot commented Oct 7, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
mcp_plex/loader
   __init__.py3861895%80–87, 161, 251–256, 633, 748–750, 752, 838–857, 1222
mcp_plex/loader/pipeline
   __init__.py16756%57–62, 68
   enrichment.py4386086%244, 249, 280, 282, 289, 293, 397, 418, 438, 446–448, 455–458, 461–463, 471, 534, 590, 613, 617, 619, 649, 667, 679, 708, 714, 717–725, 751, 754–756, 773–775, 795–798, 802, 816–822, 844, 846, 849–851
   ingestion.py1051190%78, 127–147, 174, 203, 209, 240
   orchestrator.py92595%48, 126, 155, 178–179
   persistence.py129993%112, 154–155, 165, 176, 180–182, 231
mcp_plex/server
   __init__.py6453295%52–53, 133–134, 162, 231, 237–238, 300, 304, 325–328, 345, 410, 413, 450, 468–469, 506, 1157, 1179–1185, 1221, 1239, 1244, 1262, 1386, 1423
   __main__.py440%3–8
   config.py48785%50, 52–55, 65, 76
TOTAL215315393% 

Tests Skipped Failures Errors Time
137 0 💤 0 ❌ 0 🔥 1m 3s ⏱️

@Teagan42 Teagan42 merged commit af05ce4 into main Oct 7, 2025
4 checks passed
@Teagan42 Teagan42 deleted the codex/modify-imdbcache-to-log-json-decoding-warnings branch October 7, 2025 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants