-
Notifications
You must be signed in to change notification settings - Fork 0
docs: split AGENTS instructions by package #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: split AGENTS instructions by package #78
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Splits architecture documentation into package-level AGENTS.md files and reorganizes shared code into a new common package while updating import paths and bumping the project version.
- Introduces common, loader, and server package documentation separation.
- Adds main.py entry points for loader and server.
- Updates imports and version metadata (pyproject + Docker manifest).
Reviewed Changes
Copilot reviewed 16 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_loader_unit.py | Updated imports to reflect relocation of types and IMDb cache into package submodules. |
| tests/test_load_from_plex.py | Updated TMDBShow import to new common.types path. |
| tests/test_imdb_cache.py | Adjusted IMDbCache import to new loader submodule. |
| tests/test_config.py | Updated Settings import to server.config namespacing. |
| tests/test_cache.py | Updated MediaCache import to common package. |
| pyproject.toml | Version bumped to 0.26.51. |
| docker/pyproject.deps.toml | Mirrored version bump for Docker build manifest. |
| mcp_plex/server/init.py | Updated MediaCache import to shared common package. |
| mcp_plex/server/main.py | Added CLI module (contains an async invocation issue). |
| mcp_plex/server/AGENTS.md | New server-specific architecture notes. |
| mcp_plex/loader/init.py | Updated type imports to common.types. |
| mcp_plex/loader/main.py | Added CLI module (contains an async invocation issue). |
| mcp_plex/loader/AGENTS.md | New loader-specific architecture notes. |
| mcp_plex/common/init.py | New common package exposing shared MediaCache. |
| mcp_plex/common/AGENTS.md | New shared architecture notes. |
| AGENTS.md | Trimmed root-level guide to high-level repo conventions. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
Summary
AGENTS.mdfiles withinmcp_plex/loader,mcp_plex/server, andmcp_plex/commonAGENTS.mdto cover repo-wide conventions and point to the package-level guidesWhy
Affects
Testing
uv run ruff check .uv run pytestDocumentation
AGENTS.mdfileshttps://chatgpt.com/codex/tasks/task_e_68e11a6c10348328908668bfb03a5bdb