Skip to content

Conversation

@Teagan42
Copy link
Contributor

@Teagan42 Teagan42 commented Oct 4, 2025

Summary

  • move package-specific architecture notes into new AGENTS.md files within mcp_plex/loader, mcp_plex/server, and mcp_plex/common
  • trim the root AGENTS.md to cover repo-wide conventions and point to the package-level guides
  • bump the project version to 0.26.51 and refresh the Docker manifest and lockfile

Why

  • keep contributor guidance close to the code it describes while maintaining a concise top-level reference

Affects

  • contributor documentation for loader, server, and common packages
  • project version metadata and lockfile

Testing

  • uv run ruff check .
  • uv run pytest

Documentation

  • updated root and package-level AGENTS.md files

https://chatgpt.com/codex/tasks/task_e_68e11a6c10348328908668bfb03a5bdb

Copilot AI review requested due to automatic review settings October 4, 2025 13:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Splits architecture documentation into package-level AGENTS.md files and reorganizes shared code into a new common package while updating import paths and bumping the project version.

  • Introduces common, loader, and server package documentation separation.
  • Adds main.py entry points for loader and server.
  • Updates imports and version metadata (pyproject + Docker manifest).

Reviewed Changes

Copilot reviewed 16 out of 21 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/test_loader_unit.py Updated imports to reflect relocation of types and IMDb cache into package submodules.
tests/test_load_from_plex.py Updated TMDBShow import to new common.types path.
tests/test_imdb_cache.py Adjusted IMDbCache import to new loader submodule.
tests/test_config.py Updated Settings import to server.config namespacing.
tests/test_cache.py Updated MediaCache import to common package.
pyproject.toml Version bumped to 0.26.51.
docker/pyproject.deps.toml Mirrored version bump for Docker build manifest.
mcp_plex/server/init.py Updated MediaCache import to shared common package.
mcp_plex/server/main.py Added CLI module (contains an async invocation issue).
mcp_plex/server/AGENTS.md New server-specific architecture notes.
mcp_plex/loader/init.py Updated type imports to common.types.
mcp_plex/loader/main.py Added CLI module (contains an async invocation issue).
mcp_plex/loader/AGENTS.md New loader-specific architecture notes.
mcp_plex/common/init.py New common package exposing shared MediaCache.
mcp_plex/common/AGENTS.md New shared architecture notes.
AGENTS.md Trimmed root-level guide to high-level repo conventions.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

github-actions bot commented Oct 4, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
mcp_plex/loader
   __init__.py565799%198, 253, 255–257, 273, 1279
mcp_plex/server
   __init__.py6142995%43–44, 119–120, 148, 252, 256, 277–280, 297, 362, 365, 402, 420–421, 458, 1109, 1131–1137, 1173, 1191, 1196, 1214, 1338, 1375
   __main__.py440%3–8
   config.py48785%50, 52–55, 65, 76
TOTAL14334797% 

Tests Skipped Failures Errors Time
98 0 💤 0 ❌ 0 🔥 46.761s ⏱️

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@Teagan42 Teagan42 merged commit f9666eb into main Oct 4, 2025
4 checks passed
@Teagan42 Teagan42 deleted the codex/refactor-server,-loader,-and-common-packages branch October 4, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants