Skip to content

Conversation

@Teagan42
Copy link
Contributor

@Teagan42 Teagan42 commented Oct 4, 2025

What

  • stream loader Qdrant upserts through bounded background workers so ingestion continues while batches persist and errors bubble up safely
  • adjust the loader logging concurrency test to wait deterministically for queued batches
  • bump the project version metadata and refresh the uv lockfile

Why

  • the previous scheduling awaited Qdrant batches inline once the concurrency limit was reached, which made point writes effectively synchronous with metadata fetching
  • keep the recorded package version consistent across manifests

Affects

  • loader Qdrant upsert pipeline and concurrency-focused tests
  • project version metadata

Testing

  • uv run pytest
  • uv run ruff check .

Documentation

  • no documentation changes needed

https://chatgpt.com/codex/tasks/task_e_68e177c06d8c83289078fcc110cfccb0

Copilot AI review requested due to automatic review settings October 4, 2025 19:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the loader's Qdrant upsert pipeline to parallelize operations through background workers instead of awaiting inline, improving performance by allowing ingestion to continue while batches persist. It also fixes test synchronization and updates version metadata.

  • Replaces synchronous task scheduling with bounded background workers for Qdrant upserts
  • Updates concurrency test to use deterministic waiting instead of non-blocking queue operations
  • Bumps project version from 0.26.53 to 0.26.55 across manifests

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
mcp_plex/loader/init.py Refactors upsert pipeline to use worker queue pattern with proper error handling
tests/test_loader_logging.py Fixes test synchronization and adds assertion for new log message
pyproject.toml Updates version metadata to 0.26.55
docker/pyproject.deps.toml Updates version metadata to 0.26.55

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

github-actions bot commented Oct 4, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
mcp_plex/loader
   __init__.py6282496%201, 256, 258–260, 276, 362–367, 944–949, 1072–1074, 1085–1087, 1099–1101, 1374
mcp_plex/server
   __init__.py6142995%43–44, 119–120, 148, 252, 256, 277–280, 297, 362, 365, 402, 420–421, 458, 1109, 1131–1137, 1173, 1191, 1196, 1214, 1338, 1375
   __main__.py440%3–8
   config.py48785%50, 52–55, 65, 76
TOTAL14966496% 

Tests Skipped Failures Errors Time
100 0 💤 0 ❌ 0 🔥 51.473s ⏱️

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Copilot AI review requested due to automatic review settings October 4, 2025 20:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Teagan42 Teagan42 merged commit 20fa660 into main Oct 4, 2025
4 checks passed
@Teagan42 Teagan42 deleted the codex/investigate-upserting-batch-size-mismatch branch October 4, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants