Skip to content

Conversation

@Teagan42
Copy link
Contributor

@Teagan42 Teagan42 commented Oct 5, 2025

Reverts #84

Copilot AI review requested due to automatic review settings October 5, 2025 15:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts the modular refactoring of loader tasks, consolidating previously separate ingestion, enrichment, and storage subpackages back into a single mcp_plex/loader/__init__.py file. The revert also includes updates to test assertions and version rollback.

  • Removed modular subpackages and consolidated all loader functionality into one file
  • Updated test to expect "Upsert worker" instead of "Storage worker" in logging
  • Rolled back version from 0.26.61 to 0.26.60

Reviewed Changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/test_loader_logging.py Updated test assertion to match new logging terminology
pyproject.toml Version rollback from 0.26.61 to 0.26.60
mcp_plex/loader/init.py Consolidated all loader functionality from removed subpackages
docker/pyproject.deps.toml Version rollback in dependencies file
mcp_plex/loader/utils.py Removed utility functions (moved to main module)
mcp_plex/loader/storage/* Removed storage subpackage files
mcp_plex/loader/ingestion/* Removed ingestion subpackage files
mcp_plex/loader/enrichment/* Removed enrichment subpackage files

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

github-actions bot commented Oct 5, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
mcp_plex/loader
   __init__.py84913185%243, 298, 300–302, 318, 404–409, 1011–1012, 1056, 1058, 1113–1114, 1125–1127, 1130, 1133–1134, 1136, 1158, 1168, 1179–1211, 1226, 1228, 1235–1249, 1252–1266, 1272, 1287–1318, 1323–1356, 1359–1363, 1368–1376, 1386, 1395, 1399–1401, 1520–1522, 1855
mcp_plex/server
   __init__.py6142995%43–44, 119–120, 148, 252, 256, 277–280, 297, 362, 365, 402, 420–421, 458, 1109, 1131–1137, 1173, 1191, 1196, 1214, 1338, 1375
   __main__.py440%3–8
   config.py48785%50, 52–55, 65, 76
TOTAL171717190% 

Tests Skipped Failures Errors Time
101 0 💤 0 ❌ 0 🔥 48.700s ⏱️

@Teagan42 Teagan42 merged commit c773173 into main Oct 5, 2025
4 checks passed
@Teagan42 Teagan42 deleted the revert-84-codex/rename-upsert-task-to-storage-task branch October 5, 2025 15:25
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Comment on lines 5 to 8
[project]
name = "mcp-plex"
version = "0.26.61"
version = "0.26.60"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid decreasing published package version

The version constant in pyproject.toml was changed from 0.26.61 back to 0.26.60 (mirrored in docker/pyproject.deps.toml). Our repo guidelines require bumping the version for every change; reverting to an older number breaks monotonic semantic versioning and makes it impossible to publish this artifact if 0.26.61 has already been released. Please increment to the next patch version instead of rolling the number backward.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants