-
Notifications
You must be signed in to change notification settings - Fork 0
Revert "Refactor loader tasks into modular subpackages" #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Refactor loader tasks into modular subpackages" #85
Conversation
This reverts commit 9d786a1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reverts the modular refactoring of loader tasks, consolidating previously separate ingestion, enrichment, and storage subpackages back into a single mcp_plex/loader/__init__.py file. The revert also includes updates to test assertions and version rollback.
- Removed modular subpackages and consolidated all loader functionality into one file
- Updated test to expect "Upsert worker" instead of "Storage worker" in logging
- Rolled back version from 0.26.61 to 0.26.60
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_loader_logging.py | Updated test assertion to match new logging terminology |
| pyproject.toml | Version rollback from 0.26.61 to 0.26.60 |
| mcp_plex/loader/init.py | Consolidated all loader functionality from removed subpackages |
| docker/pyproject.deps.toml | Version rollback in dependencies file |
| mcp_plex/loader/utils.py | Removed utility functions (moved to main module) |
| mcp_plex/loader/storage/* | Removed storage subpackage files |
| mcp_plex/loader/ingestion/* | Removed ingestion subpackage files |
| mcp_plex/loader/enrichment/* | Removed enrichment subpackage files |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| [project] | ||
| name = "mcp-plex" | ||
| version = "0.26.61" | ||
| version = "0.26.60" | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid decreasing published package version
The version constant in pyproject.toml was changed from 0.26.61 back to 0.26.60 (mirrored in docker/pyproject.deps.toml). Our repo guidelines require bumping the version for every change; reverting to an older number breaks monotonic semantic versioning and makes it impossible to publish this artifact if 0.26.61 has already been released. Please increment to the next patch version instead of rolling the number backward.
Useful? React with 👍 / 👎.
Reverts #84