From edfc26b6ef637c1cd60551f9ddb5a6d3c0e82c64 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Mon, 9 Sep 2019 13:16:02 +0200 Subject: [PATCH] Reduce locales used in remote translations tests This way we can reduce the number of locales used in the test environment as well, while still testing every possible scenario for remote translations. --- spec/features/remote_translations_spec.rb | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/spec/features/remote_translations_spec.rb b/spec/features/remote_translations_spec.rb index 1ff98d9..92a16d1 100644 --- a/spec/features/remote_translations_spec.rb +++ b/spec/features/remote_translations_spec.rb @@ -5,8 +5,7 @@ describe "Remote Translations" do before do Setting["feature.remote_translations"] = true create(:proposal) - available_locales_response = ["ar", "de", "en", "es", "fa", "fr", "he", "it", "nl", "pl", - "pt", "sv", "zh-Hans", "zh-Hant"] + available_locales_response = %w[de en es fr pt zh-Hans] expect(RemoteTranslations::Microsoft::AvailableLocales).to receive(:available_locales). and_return(available_locales_response) end @@ -27,18 +26,14 @@ describe "Remote Translations" do end scenario "should display text in English" do - available_locales_with_fallback_en = [:ar, :de, :fa, :he, :nl, :pl, :sv] - - visit root_path(locale: available_locales_with_fallback_en.sample) + visit root_path(locale: :de) expect(page).to have_css ".remote-translations-button" expect(page).to have_content "The content of this page is not available in your language" end scenario "should display text in English after parse key" do - available_locales_with_fallback_en = [:"zh-CN", :"zh-TW"] - - visit root_path(locale: available_locales_with_fallback_en.sample) + visit root_path(locale: :"zh-CN") expect(page).to have_css ".remote-translations-button" expect(page).to have_content "The content of this page is not available in your language" @@ -53,9 +48,7 @@ describe "Remote Translations" do end scenario "with locale that has :es fallback" do - available_locales_with_fallback_es = [:es, :fr, :it] - - visit root_path(locale: available_locales_with_fallback_es.sample) + visit root_path(locale: :fr) expect(page).to have_css ".remote-translations-button" expect(page).to have_content "El contenido de esta página no está disponible en tu idioma" @@ -72,9 +65,7 @@ describe "Remote Translations" do end scenario "Not display remote translation button when locale is not included in microsoft translate client" do - not_available_locales = [:val, :gl, :sq] - - visit root_path(locale: not_available_locales.sample) + visit root_path(locale: :nl) expect(page).not_to have_css ".remote-translations-button" end -- 2.7.4