Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stub the response to external request for available locales #3700

Merged
merged 1 commit into from Oct 1, 2019

Conversation

taitus
Copy link
Member

@taitus taitus commented Sep 13, 2019

References

Related PRs: #3235, #3236, #3237

Objectives

In remote translation tests, an external request is made to request the available languages. These specs fail when travis has connection problems and when we have not an internet connection. For these reasons we believe that it is convenient to stub the response to this request.

Visual Changes

None

Notes

The only problem with this change is when the Microsoft API is modified
It's true that the API doesn't change very often, but it may change someday... 馃

@javierm javierm added this to Reviewing in Roadmap via automation Sep 13, 2019
Roadmap automation moved this from Reviewing to Testing Sep 13, 2019
@javierm javierm changed the title [WIP] Stub the response to external request for available locales Stub the response to external request for available locales Oct 1, 2019
@javierm javierm merged commit 11d8bd6 into consuldemocracy:master Oct 1, 2019
Roadmap automation moved this from Testing to Release 1.1.0 Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Roadmap
  
Release 1.1.0
Development

Successfully merging this pull request may close these issues.

None yet

2 participants