Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename interface for consistence? #19

Closed
gmazzap opened this issue Mar 27, 2016 · 6 comments
Closed

Rename interface for consistence? #19

gmazzap opened this issue Mar 27, 2016 · 6 comments

Comments

@gmazzap
Copy link

@gmazzap gmazzap commented Mar 27, 2016

Before someone posts this article as answer, I want to say that I'm aware of it.

I also have my own opinion, but it is irrelevant here.

This is all about consistence.

ContainerInterface uses the suffix Interface, I think that for consistence would be nice if the service provider interface would be named ServiceProviderInterface.

@moufmouf
Copy link
Contributor

@moufmouf moufmouf commented Mar 29, 2016

As much as I hate it, I must admit you have a point.

If this has a chance of becoming a PSR one day, we will have to respect the PSR naming conventions, including the dreadful first rule:

Interfaces MUST be suffixed by Interface: e.g. Psr\Foo\BarInterface.

See: http://www.php-fig.org/bylaws/psr-naming-conventions/

@mnapoli : I know you hate this. Shall we make the change now or wait for a proper PSR proposal?

@mnapoli
Copy link
Member

@mnapoli mnapoli commented Apr 5, 2016

There is also this recent thread: https://groups.google.com/forum/#!topic/php-fig/Zgfd0gHUUoc This might get removed from the bylaws. What should we do?

@moufmouf
Copy link
Contributor

@moufmouf moufmouf commented Apr 6, 2016

Shall we keep this issue open until the issue is settled with the PHP-FIG?

@MidnightDesign
Copy link

@MidnightDesign MidnightDesign commented May 30, 2016

👍 Consistency

@gbprod
Copy link
Contributor

@gbprod gbprod commented Nov 8, 2016

👍 I think we should be consistant. I can make a Pull Request with this changes if you want ;)

@moufmouf
Copy link
Contributor

@moufmouf moufmouf commented Feb 16, 2017

Closed by #34

@moufmouf moufmouf closed this Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants
You can’t perform that action at this time.