Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LICENSE: fill in copyright holder #19

Merged
merged 1 commit into from
Mar 6, 2018

Conversation

stevvooe
Copy link
Member

@stevvooe stevvooe commented Mar 6, 2018

Signed-off-by: Stephen J Day stephen.day@docker.com

Closes #18

@stevvooe
Copy link
Member Author

stevvooe commented Mar 6, 2018

cc @caniszczyk @containerd/containerd-reviewers @containerd/containerd-maintainers

@caniszczyk
Copy link

I'd leave the year in, but LGTM

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevvooe
Copy link
Member Author

stevvooe commented Mar 6, 2018

I'd leave the year in

Didn't we make a different recommendation in the containerd project?

@stevvooe
Copy link
Member Author

stevvooe commented Mar 6, 2018

Actually, it has come to my attention that we need to leave the template in place and apply this to the files with The containerd Authors filled in.

cc @kunalkushwaha

Signed-off-by: Stephen J Day <stephen.day@docker.com>
@stevvooe
Copy link
Member Author

stevvooe commented Mar 6, 2018

I've updated this appropriately.

@crosbymichael
Copy link
Member

LGTM

1 similar comment
@dmcgowan
Copy link
Member

dmcgowan commented Mar 6, 2018

LGTM

@dmcgowan dmcgowan merged commit 2e1aa0d into containerd:master Mar 6, 2018
@stevvooe stevvooe deleted the identify-copyright-holders branch March 6, 2018 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants