Add OCI Volume Source support

[utam0k]

What is the problem you're trying to solve

Refers to kubernetes/enhancements#4639

Describe the solution you'd like

As far as I know, we need to add mountPoint to Image and return it in CRI.

containerd/core/images/image.go

Lines 35 to 56 in 323ba43

	type Image struct {
	// Name of the image.
	//
	// To be pulled, it must be a reference compatible with resolvers.
	//
	// This field is required.
	Name string
	// Labels provide runtime decoration for the image record.
	//
	// There is no default behavior for how these labels are propagated. They
	// only decorate the static metadata object.
	//
	// This field is optional.
	Labels map[string]string
	// Target describes the root content for this image. Typically, this is
	// a manifest, index or manifest list.
	Target ocispec.Descriptor
	CreatedAt, UpdatedAt time.Time
	}

Additional context

No response

[samuelkarp]

Seems like we also need to update the CRI API per kubernetes/kubernetes#125659.

[mikebrow]

Seems like we also need to update the CRI API per kubernetes/kubernetes#125659.

The CRI api change for this feature is now just an additional field in create container's mount list mount struct. The CRI change has already been merged:

https://github.com/containerd/containerd/blame/main/vendor/k8s.io/cri-api/pkg/apis/runtime/v1/api.pb.go#L653-L661

[wzshiming]

Can I try to implement this?

[mikebrow]

Can I try to implement this?

I was wip.. but yeah sure you can give it a shot!

[dosubot]

Hi, @utam0k. I'm Dosu, and I'm helping the containerd team manage their backlog. I'm marking this issue as stale.

Issue Summary

• You requested the addition of OCI Volume Source support by incorporating a mountPoint to the Image.
• This request is related to a Kubernetes issue, with a specific pull request referenced.
• @mikebrow confirmed that the necessary CRI API change has been merged.
• @wzshiming expressed interest in implementing the feature and was given the go-ahead to proceed.

Next Steps

• Please let us know if this issue is still relevant to the latest version of the containerd repository by commenting on this issue.
• If there is no further activity, this issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

[ghormoon]

@dosubot

still relevant, currently only cri-o supports this feature and therefore anyone who wants to use that kubernetes feature needs to migrate to it, it would be helpful of people could use it with containerd

[rotty3000]

If there is anything that I could do to keep this moving I would really love to take on the challenge as a new contributor!

[rossbachp]

Can help to made this feature moving forward?