events: move types into service package #1072
Conversation
When using events, it was found to be fairly unwieldy with a number of extra packages. For the most part, when interacting with the events service, we want types of the same version of the service. This has been accomplished by moving all events types into the events package. In addition, several fixes to the way events are marshaled have been included. Specifically, we defer to the protobuf type registration system to assemble events and type urls, with a little bit sheen on top of add a containerd.io oriented namespace. This has resulted in much cleaner event consumption and has removed the reliance on error prone type urls, in favor of concrete types. Signed-off-by: Stephen J Day <stephen.day@docker.com>
|
cc @ehazlett |
Codecov Report
@@ Coverage Diff @@
## master #1072 +/- ##
=======================================
Coverage 59.28% 59.28%
=======================================
Files 5 5
Lines 781 781
=======================================
Hits 463 463
Misses 204 204
Partials 114 114Continue to review full report at Codecov.
|
| } | ||
|
|
||
| url := typesPrefix + proto.MessageName(pb) |
| e := &event.RuntimeEvent{} | ||
| if err := proto.Unmarshal(evt.Event.Value, e); err != nil { | ||
|
|
||
| switch { |
There was a problem hiding this comment.
nit: couldn't we check if events.Is(evt.Event, &eventsapi.RuntimeEvent{}) to remove the need for the evloop label?
There was a problem hiding this comment.
even with the switch, continue without a label will affect the innermost loop: https://golang.org/ref/spec#Continue_statements
There was a problem hiding this comment.
But I agree that a switch is not needed here since there's only one case.
|
LGTM |
|
ping @dmcgowan |
Use clean path for map and comparison.
When using events, it was found to be fairly unwieldy with a number of
extra packages. For the most part, when interacting with the events
service, we want types of the same version of the service. This has been
accomplished by moving all events types into the events package.
In addition, several fixes to the way events are marshaled have been
included. Specifically, we defer to the protobuf type registration
system to assemble events and type urls, with a little bit sheen on top
of add a containerd.io oriented namespace.
This has resulted in much cleaner event consumption and has removed the
reliance on error prone type urls, in favor of concrete types.
Signed-off-by: Stephen J Day stephen.day@docker.com