Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.0] archive, cio, cmd, linux: use buffer pools #2051

Merged
merged 1 commit into from Jan 24, 2018

Conversation

stevvooe
Copy link
Member

To avoid buffer bloat in long running processes, we try to use buffer
pools where possible. This is meant to address shim memory usage issues,
but may not be the root cause.

Signed-off-by: Stephen J Day stephen.day@docker.com
(cherry picked from commit cd72819)
Signed-off-by: Stephen J Day stephen.day@docker.com

To avoid buffer bloat in long running processes, we try to use buffer
pools where possible. This is meant to address shim memory usage issues,
but may not be the root cause.

Signed-off-by: Stephen J Day <stephen.day@docker.com>
(cherry picked from commit cd72819)
Signed-off-by: Stephen J Day <stephen.day@docker.com>
@stevvooe stevvooe added this to the 1.0.2 milestone Jan 23, 2018
@codecov-io
Copy link

Codecov Report

Merging #2051 into release/1.0 will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/1.0    #2051      +/-   ##
===============================================
- Coverage        50.59%   50.57%   -0.02%     
===============================================
  Files               81       81              
  Lines             7165     7163       -2     
===============================================
- Hits              3625     3623       -2     
  Misses            2847     2847              
  Partials           693      693
Flag Coverage Δ
#linux 50.57% <100%> (-0.02%) ⬇️
Impacted Files Coverage Δ
archive/tar.go 50.46% <100%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4837f3...367eddb. Read the comment docs.

@crosbymichael
Copy link
Member

LGTM

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 0f46dd5 into containerd:release/1.0 Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants