linux: fix runtime-root propagation

[AkihiroSuda]

#2173 fixed the propagation of --runtime-root flag for ShimRemote but ShimLocal was not fixed in the commit.

This PR also adds integration test suite for config.toml.

Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp

[mlaventure]

leave it in daemon_config_linux_test.go instead for now?

[mlaventure]

This don't get cleaned up if this functions fails. Add a conditional defer on err != nil?

[AkihiroSuda]

updated

[AkihiroSuda]

this failure on travis seems unrelated (cc @Random-Liu )

https://travis-ci.org/containerd/containerd/jobs/349152244

 Failure in Spec Setup (BeforeEach) [8.799 seconds]
[k8s.io] Container Mount Propagation
/home/travis/gopath/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:72
  runtime should support mount propagation
  /home/travis/gopath/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/container_linux.go:45
    mount with 'rslave' should support propagation from host to container [BeforeEach]
    /home/travis/gopath/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/container_linux.go:128
    failed to create PodSandbox: rpc error: code = Unknown desc = failed to get sandbox image "gcr.io/google_containers/pause:3.0": failed to pull image "gcr.io/google_containers/pause:3.0": failed to pull image "gcr.io/google_containers/pause:3.0": failed to write config: ref k8s.io/11/config-sha256:5fbdc14c118c31ddd5c553f66892b846469341287a0d356485b477467cae6dd0 locked: unavailable
    Expected error:
        <*status.statusError | 0xc420202630>: {
            Code: 2,
            Message: "failed to get sandbox image \"gcr.io/google_containers/pause:3.0\": failed to pull image \"gcr.io/google_containers/pause:3.0\": failed to pull image \"gcr.io/google_containers/pause:3.0\": failed to write config: ref k8s.io/11/config-sha256:5fbdc14c118c31ddd5c553f66892b846469341287a0d356485b477467cae6dd0 locked: unavailable",
            Details: nil,
        }
        rpc error: code = Unknown desc = failed to get sandbox image "gcr.io/google_containers/pause:3.0": failed to pull image "gcr.io/google_containers/pause:3.0": failed to pull image "gcr.io/google_containers/pause:3.0": failed to write config: ref k8s.io/11/config-sha256:5fbdc14c118c31ddd5c553f66892b846469341287a0d356485b477467cae6dd0 locked: unavailable
    not to have occurred
    /home/travis/gopath/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/util.go:147
------------------------------
[BeforeEach] [k8s.io] PodSandbox

[Random-Liu]

@AkihiroSuda I saw this once. Sometimes image pulling fails when an image is being concurrently pulled. This seems to be a race condition in containerd.

See #2151 (comment)

[estesp]

LGTM

[crosbymichael]

LGTM