Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: Cross repository push #2697

Closed
wants to merge 3 commits into from

Conversation

@dmcgowan
Copy link
Member

commented Oct 3, 2018

Add label on fetch to manifest to describe source in format containerd.io/distribution.source.<host> = <repo>[,<repo>]
Update authorizer to limit parallel requests
Store token by scope
Use source annotation to set cross repository query parameters

Depends on #2690

@estesp

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2018

Hmm: failed to copy: context canceled: time="2018-10-03T08:18:53.470099229Z"

@dmcgowan dmcgowan changed the title Cross repository push wip: Cross repository push Oct 3, 2018

@dmcgowan

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2018

Marking this as WIP for now (some UI weirdness I need to fix), this can be used though to test shallow pulling/pushing

$ ctr content fetch --all-platforms --shallow <your image>
$ ctr images push -u `cat <credential file>` <new image on same registry> <your image>
``

@dmcgowan dmcgowan force-pushed the dmcgowan:cross-repo-push branch 2 times, most recently from 077e2be to e597b8a Oct 8, 2018

@dmcgowan dmcgowan added this to the 1.3 milestone Oct 18, 2018

dmcgowan added some commits Oct 2, 2018

Implement cross repository push
Add label on fetch to manifest to describe source
Update authorizer to limit parallel requests
Store token by scope
Use source annotation to set cross repository query parameters

Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Allow annotation on blobs
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Update key to use slash delimiter for host
Use a slash to make the label key more clear which is
the key and which is the host

Signed-off-by: Derek McGowan <derek@mcgstyle.net>

@dmcgowan dmcgowan force-pushed the dmcgowan:cross-repo-push branch from e597b8a to 70c1f38 Oct 23, 2018

@tonistiigi

This comment has been minimized.

Copy link
Contributor

commented Nov 7, 2018

I tried to use this PR but it didn't work. First push was ok but as soon as there were some blobs already in target repo it just deadlocks to whole push forever. This PR also regresses the regular push without any --shallow.

@ehazlett

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

@dmcgowan is this still in progress?

@dmcgowan

This comment has been minimized.

Copy link
Member Author

commented Jan 29, 2019

Yes and no, we still want this for 1.3 but I am not actively working on it. Let me create an issue and replace this

@dmcgowan dmcgowan referenced this pull request Jan 29, 2019
@dmcgowan

This comment has been minimized.

Copy link
Member Author

commented Jan 29, 2019

See #2964

@dmcgowan dmcgowan closed this Jan 29, 2019

@dmcgowan dmcgowan referenced this pull request Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.