Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user agent header to all requests #3335

Merged
merged 1 commit into from Jun 11, 2019

Conversation

dmcgowan
Copy link
Member

Currently the user agent is only being used on the initial resolve request, then switching to the default user agent. This ensures the correct user agent is always used. There is a larger fix in progress which does this is a cleaner way, but the scope of this change is fixing the user agent issue.

Currently the user agent is only being used on the initial
resolve request, then switching to the default user agent.
This ensures the correct user agent is always used. There is
a larger fix in progress which does this is a cleaner way, but
the scope of this change is fixing the user agent issue.

Signed-off-by: Derek McGowan <derek@mcgstyle.net>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 11, 2019

Build succeeded.

@codecov-io
Copy link

Codecov Report

Merging #3335 into master will increase coverage by 0.01%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3335      +/-   ##
==========================================
+ Coverage   44.83%   44.85%   +0.01%     
==========================================
  Files         113      113              
  Lines       12346    12361      +15     
==========================================
+ Hits         5535     5544       +9     
- Misses       5961     5964       +3     
- Partials      850      853       +3
Flag Coverage Δ
#linux 48.77% <73.68%> (+0.01%) ⬆️
#windows 40.25% <72.72%> (+0.02%) ⬆️
Impacted Files Coverage Δ
remotes/docker/resolver.go 54.54% <66.66%> (+0.06%) ⬆️
remotes/docker/authorizer.go 67.98% <76.92%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f69be5...bb00872. Read the comment docs.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants