Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.2] Update cri to 40affe7c7402d41618b9791a8cf105ac74ce56d0. #3674

Merged

Conversation

Random-Liu
Copy link
Member

Signed-off-by: Lantao Liu lantaol@google.com

Signed-off-by: Lantao Liu <lantaol@google.com>
@Random-Liu
Copy link
Member Author

@containerd/containerd-maintainers Do we have more bug fixes needed? Let's collect those and have a 1.2.10 as soon as possible?

@codecov-io
Copy link

Codecov Report

Merging #3674 into release/1.2 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/1.2    #3674   +/-   ##
============================================
  Coverage        44.19%   44.19%           
============================================
  Files              100      100           
  Lines            10847    10847           
============================================
  Hits              4794     4794           
  Misses            5313     5313           
  Partials           740      740
Flag Coverage Δ
#linux 47.87% <ø> (ø) ⬆️
#windows 41% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 710fca1...4be2ad7. Read the comment docs.

@estesp
Copy link
Member

estesp commented Sep 24, 2019

I don't think we have other fixes to bring for the next 1.2.x, but I do think the $PATH bug is important to get fixed ASAP. The only thing I think is worth holding up for is to see what happens with this runc security issue.

@Random-Liu
Copy link
Member Author

@estesp SG. Let's wait for the runc CVE for a few days.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Member

LGTM

@crosbymichael crosbymichael merged commit 8628ebf into containerd:release/1.2 Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants