Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mount.isFUSE(): remove unused error return, and extract FUSE unmount to a function #4588

Merged
merged 2 commits into from Oct 8, 2020

Conversation

thaJeztah
Copy link
Member

This function was added in #3765; the error itself was unused, so may as well remove it.

@thaJeztah
Copy link
Member Author

@AkihiroSuda ptal

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 28, 2020

Build succeeded.

@thaJeztah thaJeztah changed the title mount.isFUSE(): remove unused error return mount.isFUSE(): remove unused error return, and extract FUSE unmount to a function Sep 28, 2020
@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 28, 2020

Build succeeded.

mount/mount_linux.go Outdated Show resolved Hide resolved
mount/mount_linux.go Outdated Show resolved Hide resolved
mount/mount_linux.go Outdated Show resolved Hide resolved
The error itself was unused, so may as well remove it.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

@AkihiroSuda updated; I think this is what you meant; ptal

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 28, 2020

Build succeeded.

@thaJeztah thaJeztah force-pushed the remove_redundant_error branch 2 times, most recently from 0eb3105 to 9f1356f Compare October 1, 2020 15:20
@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 1, 2020

Build succeeded.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 1, 2020

Build succeeded.

Copy link
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 45d8a7e into containerd:master Oct 8, 2020
@thaJeztah thaJeztah deleted the remove_redundant_error branch October 8, 2020 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants