Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/1.4] update to golang 1.15.2 #4711

Merged
merged 1 commit into from Nov 10, 2020
Merged

[release/1.4] update to golang 1.15.2 #4711

merged 1 commit into from Nov 10, 2020

Conversation

AkihiroSuda
Copy link
Member

Cherry-pick #4050

@thaJeztah @AkihiroSuda
update to golang 1.15.2
e45f41e 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit d1c8d98)
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
Copy link
Member Author

@thaJeztah PTAL

@AkihiroSuda AkihiroSuda added this to the 1.4.2 milestone Nov 10, 2020
@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 10, 2020

Build succeeded.

Zyqsempai
Zyqsempai approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

Are we sure this is safe? I recall there were still reservations about go 1.14/1.15. The version of runc in this branch is also at v1.0.0-rc92, which was tested on Go 1.13; https://github.com/opencontainers/runc/blob/v1.0.0-rc92/Dockerfile#L1. Have changes been merged in runc after that release that relate to compatibility with Go 1.14/1.15?

At least, I know the selinux package has some changes pending release for Go 1.14 compatibility (opencontainers/selinux@v1.6.0...master (opencontainers/selinux#127)

/cc @tonistiigi @tiborvass (who had some scripts to check what syscalls are potentially called in a codebase, and could need fixing)

@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Nov 10, 2020 •
edited

runc rc92 is tested with Go 1.14 https://github.com/opencontainers/runc/blob/v1.0.0-rc92/.travis.yml#L5

mikebrow
mikebrow approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxpv mxpv merged commit 457dafa into containerd:release/1.4 Nov 10, 2020
@AkihiroSuda AkihiroSuda mentioned this pull request Nov 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxpv mxpv mxpv approved these changes

@Zyqsempai Zyqsempai Zyqsempai approved these changes

@mikebrow mikebrow mikebrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AkihiroSuda @thaJeztah @mxpv @Zyqsempai @mikebrow