Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What happens if containerd-shim is killed/dead? #667

Closed
Random-Liu opened this issue Mar 29, 2017 · 4 comments
Closed

What happens if containerd-shim is killed/dead? #667

Random-Liu opened this issue Mar 29, 2017 · 4 comments

Comments

@Random-Liu
Copy link
Member

Random-Liu commented Mar 29, 2017

What will happen if containerd-shim is killed/dead?

Based on the current implementation, things will be messed up, and the runc container will be left there.

Based on the TODO, the corresponding container will be cleaned up in next container list.

Does this mean that the client must periodically list containers to drive the cleanup? This is fine, but just want to know the expected behavior.

@mlaventure
Copy link
Contributor

That TODO also applies when containerd receives a SIGCHLD for a shim he created

@Random-Liu
Copy link
Member Author

That TODO also applies when containerd receives a SIGCHLD for a shim he created

Makes sense to me. :)

@crosbymichael
Copy link
Member

I'm working on fixing the TODO's here on restore

@zhucan
Copy link

zhucan commented Sep 17, 2021

@Random-Liu How to check the shim is active?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants