Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tracing documentation to add details about manual instrumentation #7807

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

swagatbora90
Copy link
Contributor

Add a Manual instrumentation section in docs/tracing.md and added details about how to use the tracing APIs to manual instrument spans in containerd.

Also added a section to list the naming conventions to follow.

Signed-off-by: Swagat Bora sbora@amazon.com

@k8s-ci-robot
Copy link

Hi @swagatbora90. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@swagatbora90 swagatbora90 force-pushed the tracing-documentation-update branch 2 times, most recently from b4903ff to c8e17f5 Compare December 13, 2022 21:23
@swagatbora90 swagatbora90 force-pushed the tracing-documentation-update branch 2 times, most recently from aa12610 to f606869 Compare December 13, 2022 22:50
@swagatbora90
Copy link
Contributor Author

/cc @jterry75 @mxpv PTAL

@k8s-ci-robot
Copy link

@swagatbora90: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only containerd members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @jterry75 @mxpv PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

docs/tracing.md Show resolved Hide resolved
@dims
Copy link
Member

dims commented Feb 22, 2023

@swagatbora90 one tiny NIT. LGTM otherwise. i was also curious about what to do when one component hands off to another asynchronously, but we can do that later. thanks!

docs/tracing.md Outdated Show resolved Hide resolved
@swagatbora90
Copy link
Contributor Author

swagatbora90 commented Feb 22, 2023

@swagatbora90 one tiny NIT. LGTM otherwise. i was also curious about what to do when one component hands off to another asynchronously, but we can do that later. thanks!

For correlation of two components that are related asynchronously, otel does provide a mechanism to add links between two spans https://opentelemetry.io/docs/concepts/signals/traces/#span-links. Go implementation https://github.com/open-telemetry/opentelemetry-go/blob/main/sdk/trace/span.go#L634. I have not used it myself though. Do you have any specific components in mind?

Signed-off-by: Swagat Bora <sbora@amazon.com>
@swagatbora90
Copy link
Contributor Author

@dims @mxpv I have addressed your comments. PTAL

Copy link
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jterry75
Copy link
Contributor

Thanks for adding!

@swagatbora90
Copy link
Contributor Author

Hello maintainers, is this PR okay to merge?

@estesp
Copy link
Member

estesp commented May 22, 2023

@swagatbora90 can you push this PR with no changes; seems the CI runs are too old to have the "restart" buttons anymore 🤷🏻‍♂️

@samuelkarp
Copy link
Member

Close/reopen to try and trigger CI again.

@samuelkarp samuelkarp closed this May 23, 2023
@samuelkarp samuelkarp reopened this May 23, 2023
@mxpv mxpv enabled auto-merge January 29, 2024 20:04
@mxpv
Copy link
Member

mxpv commented Jan 29, 2024

@swagatbora90 could you try to rebase this PR against latest main. I believe this will make CI happier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants