New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tracing documentation to add details about manual instrumentation #7807
base: main
Are you sure you want to change the base?
Update tracing documentation to add details about manual instrumentation #7807
Conversation
|
Hi @swagatbora90. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
b4903ff
to
c8e17f5
Compare
aa12610
to
f606869
Compare
|
@swagatbora90: GitHub didn't allow me to request PR reviews from the following users: PTAL. Note that only containerd members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@swagatbora90 one tiny NIT. LGTM otherwise. i was also curious about what to do when one component hands off to another asynchronously, but we can do that later. thanks! |
Signed-off-by: Swagat Bora <sbora@amazon.com>
72ee61a
to
2884eef
Compare
For correlation of two components that are related asynchronously, otel does provide a mechanism to add links between two spans https://opentelemetry.io/docs/concepts/signals/traces/#span-links. Go implementation https://github.com/open-telemetry/opentelemetry-go/blob/main/sdk/trace/span.go#L634. I have not used it myself though. Do you have any specific components in mind? |
Signed-off-by: Swagat Bora <sbora@amazon.com>
2884eef
to
61cec6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks for adding! |
|
Hello maintainers, is this PR okay to merge? |
|
@swagatbora90 can you push this PR with no changes; seems the CI runs are too old to have the "restart" buttons anymore 🤷🏻♂️ |
|
Close/reopen to try and trigger CI again. |
|
@swagatbora90 could you try to rebase this PR against latest |
Add a Manual instrumentation section in
docs/tracing.mdand added details about how to use the tracing APIs to manual instrument spans in containerd.Also added a section to list the naming conventions to follow.
Signed-off-by: Swagat Bora sbora@amazon.com