Conversation
|
Skipping CI for Draft Pull Request. |
b4810da to
197aa93
Compare
|
/test pull-containerd-sandboxed-node-e2e |
c779519 to
1863842
Compare
| resp, err := g.client.State(ctx, &v3.StateRequest{ | ||
| ID: request.GetID(), | ||
| ExecID: request.GetExecID(), | ||
| }) |
There was a problem hiding this comment.
Minor nit after looking again, but for all of these that don't return an emptypb we should probably just return nil for the actual responses if we got an error from the original call (g.client.State in this example) to be idiomatic
There was a problem hiding this comment.
Once we release 1.7 and switch to v3, we can clean this code (as there will be no need to convert between v2 and v3 contracts), so it'll be a lot slimmer (like sandbox/bridge.go)
|
containerd/runtime/v2/shim/shim.go Lines 279 to 284 in f82ae8a |
|
Just trialed this, we'll need at least |
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
|
Rebased against main and fixed merge conflicts. |
dcantah
left a comment
There was a problem hiding this comment.
LGTM again, dummy shim I have makes it to TaskShutdownRequest just fine if that's anything to go by 🤷
Uh oh!
There was an error while loading. Please reload this page.