Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzzing: minor change to build script #8223

Closed
wants to merge 1 commit into from

Conversation

AdamKorcz
Copy link
Contributor

use flagged parameters to instrumentation utility.

Signed-off-by: AdamKorcz <adam@adalogics.com>
@k8s-ci-robot
Copy link

Hi @AdamKorcz. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AdamKorcz
Copy link
Contributor Author

The failing fuzzing CI run should be because OSS-Fuzz has still not pulled the recent upstream changes.

@kzys
Copy link
Member

kzys commented Mar 7, 2023

@AdamKorcz Do you have a PR open for the upstream changes?

@AdamKorcz
Copy link
Contributor Author

@AdamKorcz Do you have a PR open for the upstream changes?

It has already been merged: AdamKorcz/instrumentation@eca4ee9

@kzys
Copy link
Member

kzys commented Mar 7, 2023

Sorry. I was assuming there were some upstream changes we had to have in OSS-Fuzz.

The failing fuzzing CI run should be because OSS-Fuzz has still not pulled the recent upstream changes.

Generally speaking, I'd like to merge changes when all tests are green.

@AdamKorcz
Copy link
Contributor Author

Sorry. I was assuming there were some upstream changes we had to have in OSS-Fuzz.

The failing fuzzing CI run should be because OSS-Fuzz has still not pulled the recent upstream changes.

Generally speaking, I'd like to merge changes when all tests are green.

I think CIFuzz will go green when triggered tomorrow.

@samuelkarp
Copy link
Member

Closing & reopening to trigger CI. I can't seem to trigger a rerun otherwise (maybe this has been sitting for too long?).

@samuelkarp samuelkarp closed this May 20, 2023
@samuelkarp samuelkarp reopened this May 20, 2023
@samuelkarp
Copy link
Member

@AdamKorcz Looks like this is still failing:

panic: A path should be added

goroutine 1 [running]:
main.main()
	/src/instrumentation/main.go:445 +0x68

@mxpv mxpv added the status/needs-update Awaiting contributor update label Sep 7, 2023
Copy link

github-actions bot commented Dec 7, 2023

This PR is stale because it has been open 90 days with no activity. This PR will be closed in 7 days unless new comments are made or the stale label is removed.

@github-actions github-actions bot added the Stale label Dec 7, 2023
Copy link

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants