Add From/ToProto helpers #8757
Merged
Add From/ToProto helpers #8757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helpers to convert from containerd's [Mount] to its protobuf structure for [Mount] and vice-versa appear three times. It seems sane to just expose this facility in /mount. Signed-off-by: Danny Canter <danny@dcantah.dev>
djdongjin
reviewed
Jun 28, 2023
Helpers to convert from the OCI image specs [Descriptor] to its protobuf structure for Descriptor and vice-versa appear three times. It seems sane to just expose this facility in /oci. Signed-off-by: Danny Canter <danny@dcantah.dev>
Helpers to convert from snapshot types to their protobuf structures and vice-versa appear three times. It seems sane to just expose this facility in the snapshots pkg. From/ToKind weren't used anywhere but doesn't hurt to round out the types by exposing them. Signed-off-by: Danny Canter <danny@dcantah.dev>
dcantah
force-pushed
the
proto-api-conversions
branch
from
5a948bc
to
f632b92
Compare
djdongjin
approved these changes
Jun 29, 2023
Helpers to convert from a slice of platforms to our protobuf representation and vice-versa appear a couple times. It seems sane to just expose this facility in the platforms pkg. Signed-off-by: Danny Canter <danny@dcantah.dev>
dcantah
force-pushed
the
proto-api-conversions
branch
from
f632b92
to
f3b7436
Compare
|
Oof: |
AkihiroSuda
approved these changes
Jun 29, 2023
kzys
approved these changes
Jun 30, 2023
wasup-yash
approved these changes
Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many of the core packages we have local types, and then their corresponding over the wire structures used for folks interacting via GRPC. In all these cases we have duplicated code that handles the conversions from our internal types to the generated structures. Ideally these conversions could just live next to the definitions for the internal types, and that's what this change sets out to do. I split this into four commits to make it easier if some of these aren't wanted, but the commits contain helpers to do conversions for: